Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workspace config file to default exclude #6819

Closed
wants to merge 1 commit into from
Closed

fix: add workspace config file to default exclude #6819

wants to merge 1 commit into from

Conversation

odai-alali
Copy link

@odai-alali odai-alali commented Oct 30, 2024

Description

Simple change to add vitest.workspace.ts/vitest.workspace.js to the default exclude list.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 496b9cc
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/672235adb1625e00086a6bee
😎 Deploy Preview https://deploy-preview-6819--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? Default test pattern doesn't consider workspace files as tests either.

@sheremet-va
Copy link
Member

We do not accept any changes to the default exclude because we plan to simplify it in the next major.

@odai-alali
Copy link
Author

I have the following configuration

import { configDefaults, defineConfig, mergeConfig } from 'vitest/config';

export default mergeConfig(
  viteConfig,
  defineConfig({
    test: {
      environment: 'jsdom',
      exclude: [...configDefaults.exclude, 'e2e/*'],
      root: fileURLToPath(new URL('./', import.meta.url)),
      reporters: ['default', ['junit', { outputFile: 'coverage/junit.xml' }]],
      coverage: {
        exclude: [
          ...configDefaults.exclude,
          'tailwind.config.js',
          'postcss.config.js',
        ],
      },
    },
  })
);

vitest.workspace.ts shows up in the coverage report, and I had to add it manually to fix this.

@sheremet-va
Copy link
Member

sheremet-va commented Oct 30, 2024

vitest.workspace.ts shows up in the coverage report, and I had to add it manually to fix this.

configDefault.exclude is not the same as configDefault.coverage.exclude. The first one affects what file is considered a test file. The second one is applied to the coverage, they are not related.

@odai-alali odai-alali deleted the patch-1 branch October 30, 2024 14:13
@odai-alali
Copy link
Author

Ah, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants