Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): forward inspect related cli options #7373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jan 28, 2025

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dc4c02e
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6798e1df94c5cf0008d13f5d
😎 Deploy Preview https://deploy-preview-7373--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +47 to +49
'inspect',
'inspectBrk',
'fileParallelism',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably pass --browser too, as this kind of situation is kind of weird:

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well it's not actually as simple as adding browser in the CLI overrides. The resolveConfig is overwriting browser.enabled.

@AriPerkkio AriPerkkio marked this pull request as ready for review January 28, 2025 14:54
Copy link

pkg-pr-new bot commented Jan 28, 2025

@vitest/browser

npm i https://pkg.pr.new/@vitest/browser@7373

@vitest/coverage-istanbul

npm i https://pkg.pr.new/@vitest/coverage-istanbul@7373

@vitest/expect

npm i https://pkg.pr.new/@vitest/expect@7373

@vitest/mocker

npm i https://pkg.pr.new/@vitest/mocker@7373

@vitest/coverage-v8

npm i https://pkg.pr.new/@vitest/coverage-v8@7373

@vitest/pretty-format

npm i https://pkg.pr.new/@vitest/pretty-format@7373

@vitest/runner

npm i https://pkg.pr.new/@vitest/runner@7373

@vitest/snapshot

npm i https://pkg.pr.new/@vitest/snapshot@7373

@vitest/spy

npm i https://pkg.pr.new/@vitest/spy@7373

@vitest/ui

npm i https://pkg.pr.new/@vitest/ui@7373

@vitest/utils

npm i https://pkg.pr.new/@vitest/utils@7373

vite-node

npm i https://pkg.pr.new/vite-node@7373

vitest

npm i https://pkg.pr.new/vitest@7373

@vitest/web-worker

npm i https://pkg.pr.new/@vitest/web-worker@7373

@vitest/ws-client

npm i https://pkg.pr.new/@vitest/ws-client@7373

commit: 59b6b26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vitest doesn't forward CLI options to all workspaces
1 participant