feat: Implement TypeVar for Skeleton and make SkeletonInstance Generic
#1412
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the possibility to shows to which `Skeleton` class a `SkeletonInstance` belongs. I've used this in the viur-shop a lot, otherwise it gets very complicated to know which type of Skeleton in meaned e.g. here: https://github.com/viur-framework/viur-shop/blob/caa2476c41e9b886f7961cdaa84a441dc3eb2c76/src/viur/shop/types/dc_scope.py#L25-L29
sveneberth
added
proposal
Priority: Low
sveneberth
changed the title
TypeVar for Skeleton and make SkeletonInstance Generic
sveneberth
changed the title
TypeVar for Skeleton and make SkeletonInstance GenericTypeVar for Skeleton and make SkeletonInstance Generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to shows to which
Skeletonclass aSkeletonInstancebelongs.I've used this in the viur-shop a lot, otherwise it gets very complicated to know which type of Skeleton in meaned
e.g. here: https://github.com/viur-framework/viur-shop/blob/caa2476c41e9b886f7961cdaa84a441dc3eb2c76/src/viur/shop/types/dc_scope.py#L25-L29