Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow set_status pass in skel and no key #31

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: Allow set_status pass in skel and no key #31

merged 1 commit into from
Nov 22, 2024

Conversation

ArneGudermann
Copy link
Contributor

Resolves:

We could rather implement in the toolkit.set_status that you can pass a skel, and it also reads the key from there, and you can omit the key argument
viur-framework/viur-shop#29 (comment)

sveneberth
sveneberth requested changes Nov 12, 2024
View reviewed changes
src/viur/toolkit/db.py Show resolved Hide resolved
@sveneberth sveneberth added Priority: Medium This issue may be useful, and needs some attention. enhancement New feature or request version-target:minor This change is scheduled for the next minor version labels Nov 12, 2024
sveneberth
sveneberth approved these changes Nov 13, 2024
View reviewed changes
src/viur/toolkit/db.py Show resolved Hide resolved
@sveneberth sveneberth merged commit ada467d into develop Nov 22, 2024
6 checks passed
@sveneberth sveneberth deleted the feat/set_status_allow_skel_only branch November 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveneberth sveneberth sveneberth approved these changes

@phorward phorward phorward approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Priority: Medium This issue may be useful, and needs some attention. version-target:minor This change is scheduled for the next minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArneGudermann @sveneberth @phorward