Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Import facilities for FileBone(public=True) #39

Merged

Conversation

phorward
Copy link
Member

@phorward phorward commented Jan 3, 2025

...should be backward-compatible with ViUR 3.6 (untested)

...should be backward-compatible with ViUR 3.6 (untested)
@phorward phorward requested a review from sveneberth January 3, 2025 21:35
@phorward phorward added the bug Something isn't working label Jan 3, 2025
@sveneberth sveneberth changed the base branch from main to develop January 6, 2025 15:27
@sveneberth sveneberth added enhancement New feature or request and removed bug Something isn't working labels Jan 6, 2025
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phorward FYI: I've changed the target from main to develop, as this adds a new option and is a feature (as you already stated correctly in the title by using feat:). See also: https://github.com/viur-framework/viur-toolkit?tab=readme-ov-file#branches

@sveneberth sveneberth merged commit d4fdfd7 into viur-framework:develop Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants