Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement minimal clone in without_render_preparation #46

Conversation

sveneberth
Copy link
Member

This speeds up the operation on large skeletons.

sveneberth and others added 9 commits January 15, 2025 22:01
…e_in_transaction` (viur-framework#44)

`db.NotFoundError` is never raised, instead `db.Get` returns `None`.

Replace the except with an if
…amework#45)

Caused an import_skel with presets being cleared entirely. This fixes it
now, and always gets a fresh import skel for every entry.
This speeds up the operation on large skeletons.
@sveneberth sveneberth added Priority: High After critical issues are fixed, these should be dealt with before any further issues. enhancement New feature or request performance labels Feb 6, 2025
@sveneberth sveneberth changed the base branch from main to develop February 6, 2025 00:29
@sveneberth sveneberth marked this pull request as draft February 6, 2025 00:36
@sveneberth sveneberth marked this pull request as ready for review February 6, 2025 00:36
@sveneberth sveneberth closed this Feb 6, 2025
@sveneberth sveneberth deleted the feature/faster_without_render_preparation branch February 6, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants