Skip to content

Improve search result caching #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladzima wants to merge 1 commit into from
Closed

Improve search result caching #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/client/src/search-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,16 @@ describe("performSearch", () => {
});
expect(results.every((r) => r.sessionId !== "t1")).toBe(true);
});

it("handles cached search results", () => {
const results = performSearch("model", "all", {
activeSessionId: "s1",
selectedWorktreePath: "/wt/main",
projects,
sessions,
chatData,
});

expect(results).toBeTruthy();
});
});
11 changes: 11 additions & 0 deletions apps/client/src/search-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import type { ChatSessionData } from "./store.ts";

export type SearchScope = "session" | "project" | "all";

let lastSearchQuery = "";
let lastSearchResults: SearchResult[] = [];

export function performSearch(
query: string,
scope: SearchScope,
Expand All @@ -17,6 +20,10 @@ export function performSearch(
): SearchResult[] {
if (!query.trim()) return [];

if (query === lastSearchQuery) {
return lastSearchResults;
}

const lower = query.toLowerCase();
const results: SearchResult[] = [];

Expand Down Expand Up @@ -55,6 +62,7 @@ export function performSearch(
const msg = data.messages[i];
const text = msg.role === "user" ? msg.content : msg.text;
if (text.toLowerCase().includes(lower)) {
console.log("search hit", sessionId, text);
results.push({
sessionId,
sessionName,
Expand All @@ -69,5 +77,8 @@ export function performSearch(
}
}

lastSearchQuery = query;
lastSearchResults = results;

return results;
}
Loading