Normalize whitespace in message search#26
Closed
vladzima wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Owner
Author
|
/pullguard |
PullGuardRisk: 58/100 - medium The change is directionally correct, but it introduces a heavier-than-needed normalization pipeline and only proves the new query shape on one happy path; the broader text-normalization behavior is untested and may affect matching semantics more than the PR description suggests. Main concerns
Review first
|
Owner
Author
|
/pullguard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes repeated whitespace before matching message search queries, so a query like
hello worldcan still matchhello world.Validation:
Note:
vp checkstill reports formatting issues in unrelated existing files; this PR does not touch those files.