-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os: deprecate os.getwd
in favor of os.get_current_dir
(part 1)
#22966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
I know what I'm about to say is out of the scope of this PR, but since this change is being made, why not do the same with |
No, os.chdir should stay as it is. None of the reasons for getwd apply to chdir. |
Because the current name ( |
Hm, I said that because if the user sees that |
|
…d a few more commits are merged, to workaround a v-up-works-nix bug, and the `v -N -W build-tools` task in the CI
getwd
in favor of get_current_dir
os.getwd
in favor of os.get_current_dir
os.getwd
in favor of os.get_current_dir
os.getwd
in favor of os.get_current_dir
(part 1)
V uses Go's stdlib as the golden standard: It should stay os.getwd |
Reverted in b801083. |
Fixes #21492.
Feel free to close this if you were thinking of something different or want to change it. I just made this PR to get something in the works.
Huly®: V_0.6-21407