Skip to content

build: add cross-platform Makefile for development workflows - #946

Closed
Prasannajaga wants to merge 2 commits into
vllm-project:mainfrom
Prasannajaga:bug/gemma-payload-support
Closed

build: add cross-platform Makefile for development workflows#946
Prasannajaga wants to merge 2 commits into
vllm-project:mainfrom
Prasannajaga:bug/gemma-payload-support

Conversation

@Prasannajaga

@Prasannajaga Prasannajaga commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

What is this?

Adds a root Makefile to unify standard development and quality check tasks (make check, make test-unit, make lint-check, make type-check, make sync, make lock) into simple, standardized commands.

Why is this needed?

  • Speed & Efficiency: Allows developers to run unit tests, lint checks, and type checks in a single command (make check), significantly speeding up local verification cycles.
  • Workflow Standardization: Replaces repetitive multi-step tox and uv commands with a single entry point, reducing friction for new and existing contributors across different operating systems.

git log

commit 6e0398a
Author: prasanna prasannajaga9@gmail.com
Date: Wed Jul 22 23:54:19 2026 +0530

build: add cross-platform Makefile for development workflows

Signed-off-by: prasanna <prasannajaga9@gmail.com>

commit cf6b736
Author: prasanna prasannajaga9@gmail.com
Date: Thu Jul 23 00:00:06 2026 +0530

re modification

Signed-off-by: prasanna <prasannajaga9@gmail.com>

Signed-off-by: prasanna prasannajaga9@gmail.com

Signed-off-by: prasanna <prasannajaga9@gmail.com>
Signed-off-by: prasanna <prasannajaga9@gmail.com>
@Prasannajaga
Prasannajaga force-pushed the bug/gemma-payload-support branch from a0ae8de to cf6b736 Compare July 22, 2026 18:30
@Prasannajaga

Copy link
Copy Markdown
Contributor Author

@jaredoconnell @dbutenhof adding this would greatly improve the dev workflow

@sjmonson

Copy link
Copy Markdown
Collaborator

Rejecting as this provides no value. Its essentially aliasing tox commands.

@sjmonson sjmonson closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants