merge queue: checking main (9a2980e) and #615 together - #975
Closed
mergify[bot] wants to merge 8 commits into
Closed
merge queue: checking main (9a2980e) and #615 together#975mergify[bot] wants to merge 8 commits into
mergify[bot] wants to merge 8 commits into
Conversation
Signed-off-by: Uri Shaket <ushaket@redhat.com>
Signed-off-by: Uri Shaket <ushaket@redhat.com>
Signed-off-by: Uri Shaket <ushaket@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Add post_validation to OpenAIRequestHandler and OpenAIWSRequestHandler protocols with a permissive no-op default. TextCompletionsRequestHandler and ResponsesRequestHandler override with a check for text, tool_calls, or output_tokens. PoolingRequestHandler and EmbeddingsRequestHandler keep the default no-op since they produce non-text output. Validation is called from the backend resolve methods (http.py, websocket.py) after compile, not inside each handler's compile methods. Cancellation paths skip validation for partial responses. Fixes tool-call-only false negative: responses with tool_calls but no text are now correctly treated as valid output. Assisted-by: Claude Signed-off-by: Uri Shaket <ushaket@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Extract _validate_text_response helper shared by TextCompletionsRequestHandler and ResponsesRequestHandler. Add docstrings to all post_validation overrides. Assisted-by: Claude Signed-off-by: Uri Shaket <ushaket@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (9a2980e) and #615 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #615.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleMerge Requirements]Merge Requirements]:check-success = @github-actions/quality (3.10) / type-checkscheck-neutral = @github-actions/quality (3.10) / type-checkscheck-skipped = @github-actions/quality (3.10) / type-checksMerge Requirements]:check-success = @github-actions/quality (3.10) / precommit-checkscheck-neutral = @github-actions/quality (3.10) / precommit-checkscheck-skipped = @github-actions/quality (3.10) / precommit-checksMerge Requirements]:check-success = @github-actions/quality (3.10) / quality-checkscheck-neutral = @github-actions/quality (3.10) / quality-checkscheck-skipped = @github-actions/quality (3.10) / quality-checksMerge Requirements]:check-success = @github-actions/tests (3.10) / e2e-testscheck-neutral = @github-actions/tests (3.10) / e2e-testscheck-skipped = @github-actions/tests (3.10) / e2e-testsMerge Requirements]:check-success = @github-actions/tests (3.10) / integration-testscheck-neutral = @github-actions/tests (3.10) / integration-testscheck-skipped = @github-actions/tests (3.10) / integration-testsMerge Requirements]:check-success = @github-actions/tests (3.10) / unit-testscheck-neutral = @github-actions/tests (3.10) / unit-testscheck-skipped = @github-actions/tests (3.10) / unit-testsMerge Requirements]:check-success = @github-actions/update-descriptioncheck-neutral = @github-actions/update-descriptioncheck-skipped = @github-actions/update-descriptionRequired conditions to stay in the queue:
#approved-reviews-by >= 1#changes-requested-reviews-by = 0-closed-draftcheck-success = DCOcheck-success = update-description