[Transforms] Use get_head_dim util

[kylesayrs]

Purpose

• Reduce code duplication

Prerequisites

• [Transform] Attention/Cache transforms compressed-tensors#436

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

[gemini-code-assist]

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to reduce code duplication and improve maintainability within the llmcompressor library by leveraging a shared utility function, get_head_dim, for determining the head dimension of a model. This change centralizes the logic, making the codebase more consistent and easier to manage.

Highlights

• Code Refactoring: The pull request refactors the SpinquantModifier to utilize the get_head_dim utility function, centralizing the logic for determining the head dimension of a model.
• Reduced Duplication: The head_dim calculation logic, previously duplicated within the _create_r2_scheme method, has been removed and replaced by a single call to the get_head_dim utility.
• Method Signature Updates: The _create_r2_scheme and _create_r3_scheme methods now accept head_dim as a direct argument, improving their clarity and reducing their internal complexity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the SpinQuantModifier to use the get_head_dim utility, which is a good step towards reducing code duplication. However, this refactoring appears to have unintentionally removed important logic for handling transform_block_size within the _create_r2_scheme method. I've included a review comment with a suggested fix to restore this functionality and prevent a behavioral regression.

[brian-dellabetta]

cool