-
Couldn't load subscription status.
- Fork 266
[Cache] Check cache before recipe fetch, for offline mode #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously, recipe_from_huggingface_model_id() would attempt network requests to huggingface.co even in offline environments, causing connection errors during model saving when trying to fetch recipe.yaml. This change enables true offline operation by: - Checking local HuggingFace cache for recipe.yaml before attempting network requests using try_to_load_from_cache() - Respecting HF_HUB_OFFLINE environment variable to skip network requests when explicitly in offline mode - Maintaining backward compatibility with existing online workflows The implementation checks the cache first (efficient), then respects the offline flag, and only falls back to network requests when necessary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Ralph Bean <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @ralphbean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's ability to function seamlessly in offline environments by optimizing how model recipes are fetched from Hugging Face. It introduces a proactive check of the local cache for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
b172df4 to
2421e18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the application's ability to operate in offline environments by checking the local Hugging Face cache for recipe files and respecting the HF_HUB_OFFLINE environment variable. This prevents unnecessary network requests when offline. The changes involve modifying several files to remove the cache_dir argument and updating the recipe loading logic to prioritize the local cache and respect the offline mode setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Previously, recipe_from_huggingface_model_id() would attempt network
requests to huggingface.co even in offline environments, causing
connection errors during model saving when trying to fetch recipe.yaml.
This change supports offline operation by:
network requests using try_to_load_from_cache()
requests when explicitly in offline mode