Minimax M3 agg - #682
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request updates the speculative decoding configuration for the MiniMax-M3 model in models/MiniMaxAI/MiniMax-M3.yaml. It restructures the spec_decoding feature to support multiple modes, introducing a standard mode for single-node and multi-node serving, and a new gqa mode recommended for disaggregated serving. Both modes include hardware overrides for AMD to use the Triton attention backend. No review comments were provided, so there is no additional feedback.
|
Thanks for adding One suggestion while this is open, since it also adds the GQA draft head "recommended for disaggregated (pd_cluster) serving": our disaggregated NVFP4 recipes set two more keys in the same attention config that the current {"backend": "FLASHINFER", "use_trtllm_attention": true, "indexer_kv_dtype": "fp8"}So the split we see in practice is:
If that reflects your intent for the pd_cluster path too, it might be worth folding the two extra keys in here (dotted form, matching your style): - "--attention_config.backend"
- "FLASHINFER"
- "--attention_config.use_trtllm_attention"
- "true"Possibly gated to the disaggregated strategy rather than set unconditionally on the variant, since the single-node lanes don't pass them. Evidence — these are the InferenceX configs the values come from (all three still in review, not yet merged, so treat as FYI rather than settled):
Happy to open a follow-up PR with just those two keys after this merges, if you'd rather keep this one scoped to the GQA/indexer change. |
|
Thanks — the current head I reproduced the Vercel failure. The PR is still based on 中文:当前提交 我已复现 Vercel 失败。该 PR 仍基于 |
|
Validated this as the existing upstream artifact for SemiAnalysisAI/InferenceX#2120; no duplicate PR is needed.
One command-parity issue remains before I can call every exposed combination supported: the exact non-EAGLE B200/B300 command normalizes cleanly, but the generated EAGLE3 command also inherits Two metadata/CI finish items:
Once the command-scope question is resolved and the refreshed branch is green, this existing PR is the correct artifact to merge. 中文: 已确认本 PR 就是 SemiAnalysisAI/InferenceX#2120 对应的上游产物,无需再创建重复 PR。
目前仍有一个命令等价性问题,解决前不能把所有暴露出的组合都视为已验证支持:非 EAGLE 的 B200/B300 命令可完成规范化对齐,但生成的 EAGLE3 命令也会从 还需要完成两项元数据/CI 工作:
命令适用范围确认完成且更新后的分支变绿后,这个现有 PR 就是应当合并的正确产物。 |
|
Revalidated the new head One correction to my prior command-scope note: the exact InferenceX #2314 disaggregated GQA recipes do pass There is still one exact
I do not see source evidence here for the generated 3/3 cross-product. Please either provide runtime evidence for 3/3, add a faithful per-role mode representation, or keep the exact GQA 中文:已重新验证新 head 更正此前关于命令适用范围的一点:InferenceX #2314 的精确分离式 GQA 配置确实在预填充和解码两侧都通过 但在将 GQA 模式描述为可运行或推荐的 #2310 的非投机服务端共同配置仍然准确有效,即 |
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
8014fd5 to
2f9f8f9
Compare
Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Set the MSA indexer KV cache to FP8 on the MiniMax-M3 NVFP4 and MXFP8 variants for B200/B300 serving. Based on SemiAnalysisAI/InferenceX#2120 and SemiAnalysisAI/InferenceX#2337.