fix dflash converter issues - #662
Conversation
Signed-off-by: shanjiaz <hezhao@redhat.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR updates DFlash conversion to resolve ChangesCheckpoint conversion and verifier forwarding
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The quality checks have failed. Please run |
rahul-tuli
left a comment
There was a problem hiding this comment.
By making verifier a named param and consuming it (no longer in **kwargs), it's never forwarded to the constructor anymore. So EagleSpeculator gets verifier=None, falls back to the config's name_or_path, and tries to load that instead of using the passed-in object. I believe that would break test_eagle_speculator_from_pretrained_different_layers and ..._local_marshalling_different_layers at runtime (they assert model.verifier == mock_verifier)
Signed-off-by: shanjiaz <hezhao@redhat.com>
rahul-tuli
left a comment
There was a problem hiding this comment.
LGTM; The failing tests seem to be unrelated to this PR 🚢
Purpose
Fixing two separate issues:
block_sizeon top level but newer models have them nested underdflash_config.Tests
Tested both locally.
Checklist
I have filled in:
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.