Skip to content

Remove stale vLLM compatibility warning for draft arch - #681

Closed
orestis-z wants to merge 1 commit into
vllm-project:mainfrom
orestis-z:fix/align-qwen3-default-in-train-helper
Closed

Remove stale vLLM compatibility warning for draft arch#681
orestis-z wants to merge 1 commit into
vllm-project:mainfrom
orestis-z:fix/align-qwen3-default-in-train-helper

Conversation

@orestis-z

@orestis-z orestis-z commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Run training with default args — no spurious warning emitted

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

In scripts/train.py, the create_transformer_layer_config function's draft_arch parameter default is changed from "llama" to "qwen3", and the warnings.warn call that previously fired when draft_arch != "llama" is removed.

Changes

draft_arch default and warning update

Layer / File(s) Summary
Default and warning removal
scripts/train.py
draft_arch parameter default changed from "llama" to "qwen3"; the conditional warnings.warn block for non-"llama" architectures is removed, while the validation against DRAFT_ARCH_CONFIGS is retained.

Possibly related PRs

  • vllm-project/speculators#620: Directly modifies the same draft_arch default in scripts/train.py, switching from "llama" to "qwen3" in the same function.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change by calling out removal of the stale vLLM compatibility warning.
Description check ✅ Passed The description accurately summarizes the warning removal and notes the supported draft architectures.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jun 29, 2026

Copy link
Copy Markdown

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @orestis-z.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 29, 2026
PR vllm-project#620 changed the argparse default to qwen3 but missed the
function-level default in create_transformer_layer_config and left a
warning that now fires on every default training run.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
@orestis-z
orestis-z force-pushed the fix/align-qwen3-default-in-train-helper branch from 733e4f1 to 315e065 Compare June 29, 2026 12:16

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/train.py`:
- Line 107: The default for draft_arch in the training flow is inconsistent
between the helper and the CLI/docs, so the new value is not actually used by
the main path. Update parse_args() in relation to the --draft-arch argument, the
related help text/docs, and the main() call site so they all agree with the
intended default, or keep the helper default in sync until those contracts are
changed together.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d8246e1c-47cb-4da0-b859-336e62e17068

📥 Commits

Reviewing files that changed from the base of the PR and between c5e7b8a and 733e4f1.

📒 Files selected for processing (1)
  • scripts/train.py

Comment thread scripts/train.py Outdated
@orestis-z orestis-z changed the title Fix stale llama default and warning missed by #620 Remove stale vLLM compatibility warning for draft arch Jun 29, 2026
@orestis-z orestis-z self-assigned this Jun 29, 2026
@mergify mergify Bot removed the needs-rebase label Jun 29, 2026
@orestis-z orestis-z added the ready This PR is ready for review label Jun 29, 2026
@orestis-z
orestis-z enabled auto-merge (squash) June 29, 2026 12:17
@orestis-z
orestis-z requested a review from shanjiaz June 29, 2026 12:17
@orestis-z
orestis-z marked this pull request as draft June 29, 2026 12:18
auto-merge was automatically disabled June 29, 2026 12:18

Pull request was converted to draft

@orestis-z
orestis-z removed the request for review from shanjiaz June 29, 2026 12:18
@orestis-z

Copy link
Copy Markdown
Collaborator Author

Closing — the upstream warning was already updated in a later commit to only warn for architectures other than llama/qwen3, which is valid. Nothing left to fix here.

@orestis-z orestis-z closed this Jun 29, 2026
@orestis-z orestis-z removed the ready This PR is ready for review label Jun 29, 2026
@orestis-z orestis-z removed their assignment Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant