Remove stale vLLM compatibility warning for draft arch - #681
Conversation
📝 WalkthroughWalkthroughIn Changesdraft_arch default and warning update
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has merge conflicts that must be resolved before it can be |
PR vllm-project#620 changed the argparse default to qwen3 but missed the function-level default in create_transformer_layer_config and left a warning that now fires on every default training run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
733e4f1 to
315e065
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/train.py`:
- Line 107: The default for draft_arch in the training flow is inconsistent
between the helper and the CLI/docs, so the new value is not actually used by
the main path. Update parse_args() in relation to the --draft-arch argument, the
related help text/docs, and the main() call site so they all agree with the
intended default, or keep the helper default in sync until those contracts are
changed together.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d8246e1c-47cb-4da0-b859-336e62e17068
📒 Files selected for processing (1)
scripts/train.py
Pull request was converted to draft
|
Closing — the upstream warning was already updated in a later commit to only warn for architectures other than llama/qwen3, which is valid. Nothing left to fix here. |
Summary
create_transformer_layer_configthat was missed by Change default drafter architecture from Llama to Qwen3 #620Test plan
🤖 Generated with Claude Code