Skip to content

Add PR review cron: skill, script, and CONTRIBUTING.md check#789

Draft
orestis-z wants to merge 6 commits into
mainfrom
feat/pr-review-cron-v2
Draft

Add PR review cron: skill, script, and CONTRIBUTING.md check#789
orestis-z wants to merge 6 commits into
mainfrom
feat/pr-review-cron-v2

Conversation

@orestis-z

Copy link
Copy Markdown
Collaborator

Summary

  • Adds review-open-prs skill — orchestrator that fetches open PRs, filters for reviewable ones (non-draft, unapproved, recent activity), and spawns parallel /pr-review agents
  • Adds scripts/review-open-prs.sh — headless cron wrapper with Vertex AI auth, claude-runner user switch, and self-copy-to-/tmp for safe git reset --hard origin/main
  • Adds Phase 3.7 (CONTRIBUTING.md compliance) to /pr-review skill: checks issue linkage for significant changes, DCO sign-off, and doc updates for behavior changes

Bug fixes (from prior cron runs)

  • Fixed cd after /tmp re-exec resolving to / instead of the repo dir — caused "not a git repository" errors
  • Skill + script now live on main so they survive git reset --hard origin/main

Test plan

  • Run scripts/review-open-prs.sh --interactive to verify skill discovery and review flow
  • Run via cron and confirm pr-review.log shows successful reviews instead of "Unknown command" errors
  • Verify Phase 3.7 flags a PR missing DCO sign-off or issue linkage

🤖 Generated with Claude Code

orestis-z and others added 3 commits July 14, 2026 13:55
Three new high-level checks at the top of Phase 3 (design review),
evaluated before line-level analysis:
- Bloat: vendored files, generated content, IDE files
- AI slop: excessive docstrings, over-commenting, cargo-culted patterns
- Splittability: independent changes bundled in one PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Phase 3.7 verifies issue linkage for significant changes, DCO
sign-off on commits, and doc updates for behavior changes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Adds the orchestrator skill that fetches open PRs, filters for
reviewable ones, and spawns parallel /pr-review agents. Includes
the headless cron wrapper script with Vertex AI auth, claude-runner
user switch, and self-copy-to-/tmp for safe git reset.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
@orestis-z
orestis-z marked this pull request as draft July 14, 2026 13:57
orestis-z added a commit that referenced this pull request Jul 14, 2026
After git reset --hard origin/main, the review-open-prs skill is
missing until PR #789 merges. Fall back to the feature branch.
Becomes a no-op once merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1f97cdf2-238b-45ec-b107-22a8f256a1b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pr-review-cron-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

orestis-z and others added 3 commits July 14, 2026 13:58
After git reset --hard origin/main, the review-open-prs skill is
missing until PR #789 merges. Fall back to the feature branch.
Becomes a no-op once merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
Three bugs fixed:
- REPO_DIR recomputed from /tmp path on re-exec, resolving to /
- Git fetch/reset ran again as claude-runner (permission denied)
- Moved git ops + user switch into single root-only block

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Orestis Zambounis <orestis.zambounis@gmail.com>
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require approval from approved reviewers list 👀 reviews

🔴 Require approval from approved reviewers list

Waiting for any of

  • approved-reviews-by = dsikka
  • approved-reviews-by = fynnsu
  • approved-reviews-by = orestis-z
  • approved-reviews-by = rahul-tuli
  • approved-reviews-by = shanjiaz
This rule is failing.

All pull requests must have at least one approving review from a member of the approved reviewers list before merging.

  • any of:
    • approved-reviews-by = dsikka
    • approved-reviews-by = fynnsu
    • approved-reviews-by = orestis-z
    • approved-reviews-by = rahul-tuli
    • approved-reviews-by = shanjiaz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant