Skip to content

Document P-EAGLE and DSpark training arguments#857

Open
guan404ming wants to merge 1 commit into
vllm-project:mainfrom
guan404ming:docs-train-args-peagle-dspark
Open

Document P-EAGLE and DSpark training arguments#857
guan404ming wants to merge 1 commit into
vllm-project:mainfrom
guan404ming:docs-train-args-peagle-dspark

Conversation

@guan404ming

@guan404ming guan404ming commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Purpose

docs/cli/train.md documents Eagle3-Specific and DFlash-Specific arguments, but the P-EAGLE and DSpark flags are missing. Defaults and descriptions are taken from scripts/train.py.

  • P-EAGLE-Specific Arguments (new section)
  • DSpark-Specific Arguments (new section)
  • DFlash-Specific Arguments (extended -- D-PACE is shared by DFlash and DSpark)

Tests

Docs-only. mdformat --check passes.

Checklist

I have filled in:

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan/results, such as providing test command and pasting the results.
  • (Optional) The necessary documentation update.
  • I (a human) have written or reviewed the code in this pr to the best of my ability.

Signed-off-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f0dd2e7b-5e2c-4eac-aa18-29345967c7f8

📥 Commits

Reviewing files that changed from the base of the PR and between f5e2450 and b55fb35.

📒 Files selected for processing (1)
  • docs/cli/train.md

📝 Walkthrough

Walkthrough

Changes

CLI Speculator Documentation

Layer / File(s) Summary
Document speculator-specific training options
docs/cli/train.md
Adds P-EAGLE sampling arguments and DSpark per-position loss, Markov-head, and confidence-head configuration options.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main documentation change for P-EAGLE and DSpark training arguments.
Description check ✅ Passed The description matches the docs-only update and correctly describes the added P-EAGLE and DSpark sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the documentation Improvements or additions to documentation label Jul 24, 2026
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require approval from approved reviewers list 👀 reviews

🔴 Require approval from approved reviewers list

Waiting for any of

  • approved-reviews-by = dsikka
  • approved-reviews-by = fynnsu
  • approved-reviews-by = orestis-z
  • approved-reviews-by = rahul-tuli
  • approved-reviews-by = shanjiaz
This rule is failing.

All pull requests must have at least one approving review from a member of the approved reviewers list before merging.

  • any of:
    • approved-reviews-by = dsikka
    • approved-reviews-by = fynnsu
    • approved-reviews-by = orestis-z
    • approved-reviews-by = rahul-tuli
    • approved-reviews-by = shanjiaz

@guan404ming
guan404ming marked this pull request as ready for review July 24, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant