Honour --group-size when replaying a trace, and read traces from GCS - #3389
Merged
Conversation
--group-size was silently ignored whenever --trace-file was given, since the stream count came straight from len(specs). Runs meant to sweep batch size all replayed the trace's full group instead, which is easy to miss because the only sign is the stream count in the report. Trim each group to --group-size at load time, warn when it exceeds what the trace holds, and default it to None so a trace still replays whole unless asked. --trace-file also went through open(), so a gs:// URI failed. Accept one directly, via google-cloud-storage when installed and the gsutil CLI otherwise, so neither is a hard dependency. Signed-off-by: wenxindongwork <wenxindong@google.com>
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
wenxindongwork
marked this pull request as ready for review
August 13, 2026 21:16
Signed-off-by: wenxindongwork <wenxindong@google.com>
wenxindongwork
enabled auto-merge (squash)
August 13, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small usability fixes to the agentic benchmark, both hit while sweeping batch size against the MLPerf traces.
--group-sizewas ignored when replaying a tracerun_grouptook its stream count fromlen(specs), so--group-sizedid nothing whenever--trace-filewas supplied. A run intending 8 streams silently replayed the trace's full 16, and the only visible sign was the stream count buried in the report — easy to miss, and it quietly invalidates a batch-size sweep.Each group is now trimmed to
--group-sizeat load time, so the startup summary and the run agree.--trace-filenow acceptsgs://