Skip to content

Conversation

@leo-pony
Copy link
Collaborator

@leo-pony leo-pony commented Nov 26, 2025

What this PR does / why we need it?

Fix the ray start failed bug: local_world_size cannot little than visible device count error
detail see issue #4456.

This fix code is copied from vllm fixing modify, PR: #28873

Does this PR introduce any user-facing change?

How was this patch tested?

  • vLLM version: v0.11.2

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug where ray start would fail due to an incorrect assertion on local_world_size. The change correctly adds a condition to skip this assertion when using ray or external_launcher as the distributed backend. The fix seems correct and addresses the issue described. I have one suggestion to improve code consistency and readability.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@leo-pony
Copy link
Collaborator Author

leo-pony commented Nov 26, 2025

@wangxiyuan It's ready for review. Could your help review?
Test case:
I test with 2 * atlas A3 nodes, with pp2 * tp16, successfully starting and running inference:
Ray start successfully, and qwen3-235B-30B successully running:
4e5b8b0c-4d78-4fc9-a693-f0f15fb5ccc8
d465d430-dfd2-4166-a327-358e3c1314fd
The inference request successfully returned:
c5f3d578-83b6-4a3e-9448-bc06e1d22360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant