Skip to content

Conversation

@jesse996
Copy link
Contributor

@jesse996 jesse996 commented Nov 26, 2025

What this PR does / why we need it?

this PR is based on PR vllm-project/vllm#24799 ,and aims to support spec decode with async_scheduling.
and fix crash in Eagle Speculative Decoding models when the input length exceed the drafter model length but not the verifier's based on pr vllm-project/vllm#24662

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for speculative decoding with asynchronous scheduling on Ascend NPUs. The changes are primarily within vllm_ascend/worker/model_runner_v1.py, modifying the model execution and token sampling logic to handle the new asynchronous speculative decoding path. While the overall approach seems reasonable, my review has identified several critical issues that need to be addressed. These include a logic error that nullifies the speculative decoding output processing, duplicated code blocks, and incorrect usage of CUDA-specific stream APIs instead of the appropriate NPU APIs for the Ascend platform. There is also a syntax error that appears to be a merge artifact. These issues will prevent the code from functioning correctly and must be fixed.

Signed-off-by: jesse <[email protected]>
Signed-off-by: jesse <[email protected]>
Signed-off-by: jesse <[email protected]>
Signed-off-by: jesse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant