Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 27, 2025

Purpose

With all models migrated in #26149, we can begin the process of phasing out merge_by_field_config=False. After v0.12, we will switch the default value of SupportsMultiModal.merge_by_field_config to True, then later remove the merge_by_field_config argument from group_mm_kwargs_by_modality entirely.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337 DarkLight1337 added ready ONLY add when PR is ready to merge/full CI is needed multi-modality Related to multi-modality (#4194) labels Oct 27, 2025
@DarkLight1337 DarkLight1337 moved this to In Progress in Multi-modality Core Oct 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a deprecation warning for merge_by_field_config=False in group_mm_kwargs_by_modality. The changes are straightforward and align with the goal of phasing out the legacy multi-modal kwarg batching. I've pointed out a potential inconsistency in the deprecation timeline mentioned in the warning message versus the PR description, which could be confusing for users. Otherwise, the changes look good.

if merge_by_field_config is False:
logger.warning_once(
"The legacy code for batching multi-modal kwargs is deprecated and "
"will be removed in v0.12. Please update your model with "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The deprecation warning message on this line states that the legacy code will be removed "in v0.12". However, the pull request description outlines a more gradual deprecation plan: "After v0.12, we will switch the default value ... then later remove the merge_by_field_config argument...". This suggests the removal will happen in a version after 0.12 (e.g., v0.13 or later). To provide a clear and accurate deprecation path for users, the warning message should be consistent with the planned timeline. I recommend updating the version mentioned in the warning to avoid confusion.

Suggested change
"will be removed in v0.12. Please update your model with "
"will be removed in a future version. Please update your model with "

@DarkLight1337 DarkLight1337 merged commit b368382 into vllm-project:main Oct 27, 2025
51 checks passed
@DarkLight1337 DarkLight1337 deleted the deprecate-batch-kwargs branch October 27, 2025 08:43
@github-project-automation github-project-automation bot moved this from In Progress to Done in Multi-modality Core Oct 27, 2025
xuhaolei pushed a commit to ZJU-REAL/EasySteer-vllm-v1 that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants