[Doc] Slight improvement to M2 and beyond #27554
Conversation
Signed-off-by: Jee Jee Li <[email protected]>
|
Documentation preview: https://vllm--27554.org.readthedocs.build/en/27554/ |
Signed-off-by: Jee Jee Li <[email protected]>
| | [ERNIE-4.5-21B-A3B-Thinking](https://huggingface.co/baidu/ERNIE-4.5-21B-A3B-Thinking) | `ernie45` | `json`, `regex` | ✅ | | ||
| | [QwQ-32B](https://huggingface.co/Qwen/QwQ-32B) | `deepseek_r1` | `json`, `regex` | ✅ | | ||
| | [GLM-4.5 series](https://huggingface.co/collections/zai-org/glm-45-687c621d34bda8c9e4bf503b) | `glm45` | `json`, `regex` | ✅ | | ||
| | [Hunyuan A13B series](https://huggingface.co/collections/tencent/hunyuan-a13b-685ec38e5b46321e3ea7c4be) | `hunyuan_a13b` | `json`, `regex` | ✅ | |
There was a problem hiding this comment.
Sort alphabetically
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Jee Jee Li <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the MiniMax-M2 model and includes some documentation improvements. The changes to enable online availability for MiniMax-M2 and the refactoring in the model implementation are reasonable. However, a significant portion of the model tests in tests/models/registry.py has been commented out. This is a critical issue as it can mask regressions across various model types. This change needs to be justified or reverted.
Signed-off-by: Jee Jee Li <[email protected]>
github-actions
bot
added
the
ready
Signed-off-by: Jee Jee Li <[email protected]> Co-authored-by: Roger Wang <[email protected]>
3 participants
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.