[Rust Frontend] Use oss-harmony for Harmony output processing#46799
Merged
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
4 tasks
njhill
approved these changes
Jun 26, 2026
wincent8
pushed a commit
to wincent8/vllm
that referenced
this pull request
Jun 29, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Switch the library used for Harmony output processing from
Inferact/openai-harmony(introduced in #46696) tooss-harmony, a more actively maintained fork of the original library.This gives the Rust frontend two practical benefits:
reqwest/ TLS backend dependency from Harmony output processingThis PR is the dependency-only base for the follow-up GPT-OSS Harmony renderer work.
Test Plan
cargo nextest run --manifest-path rust/Cargo.toml -p vllm-chat output::harmonycargo check --manifest-path rust/Cargo.toml -p vllm-chat --lockedTest Result
Both commands passed locally.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.