Revert "[Sampler] Stop upcasting logits to fp32 in apply_sampling_params" (#48641)#49033
Draft
vllm-agent wants to merge 1 commit into
Draft
Revert "[Sampler] Stop upcasting logits to fp32 in apply_sampling_params" (#48641)#49033vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
…ams (vllm-project#48641)" This reverts commit 425c4ea.
Member
|
#48641 is unlikely to be the cause of this failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #48641 ("[Sampler] Stop upcasting logits to fp32 in apply_sampling_params").
Reason: This PR is linked to 1 new nightly CI failure in build #78700:
LM Eval Qwen3.5 Models (2xB200)The MTP variant of
Qwen3.5-397B-A17B-NVFP4hung insample_tokens(fatalTimeoutError: RPC call to sample_tokens timed out) while the identical non-MTP variant of the same model passed. This PR replaced the fresh fp32 logits copy with in-place bf16 mutation inapply_sampling_params, which plausibly corrupts spec-decode verification numerics and desyncs the DP=2 ranks.Auto-generated by CI failure analyzer.