Make load_weights completely optional#49038
Open
hmellor wants to merge 17 commits into
Open
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…d weights Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This was referenced Jul 18, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
marked this pull request as ready for review
July 19, 2026 14:45
hmellor
requested review from
22quinn,
AndreasKaratzas,
DarkLight1337,
njhill,
patrickvonplaten,
sighingnow,
tomeras91,
vadiklyutiy,
ywang96 and
zyongye
as code owners
July 19, 2026 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #48972
Infrastructure changes:
autoload_weightsand use it in weight loaders and runners. This creates it's ownAutoWeightsLoaderif the model doesn't have aload_weightsmethodload_weightsmethod, auto apply anyhf_to_vllm_mapperinAutoWeightsLoader._load_moduleas the model is recursed intoskip_prefixandskip_substrsfromAutoWeightsLoader. These arguments duplicate the behaviour achievable with the mapper. Convert all uses of these arguments to mapper mappingslm_headskipping for models withtie_word_embeddingsso every model doesn't need to specify this manuallyfused_qkv_interleavedtoQKVParallelLinearso that it can de-interleave a fused weight itself