Skip to content

[Bugfix] Propagate VLLM_MARLIN_INPUT_DTYPE into INC/AutoRound quant path#49039

Open
lazypool wants to merge 1 commit into
vllm-project:mainfrom
lazypool:fix/inc-marlin-input-dtype
Open

[Bugfix] Propagate VLLM_MARLIN_INPUT_DTYPE into INC/AutoRound quant path#49039
lazypool wants to merge 1 commit into
vllm-project:mainfrom
lazypool:fix/inc-marlin-input-dtype

Conversation

@lazypool

@lazypool lazypool commented Jul 18, 2026

Copy link
Copy Markdown

Fixes #48904.

AutoRound (INC) checkpoints route through inc_wna16_linear.py and inc_wna16_scheme.py, which construct Marlin linear/MoE methods but never assign input_dtype. The attribute defaults to None, so the Marlin kernel never enters the int8-activation branch regardless of the VLLM_MARLIN_INPUT_DTYPE env var.

Fix by setting method.input_dtype = get_marlin_input_dtype() after construction, matching the pattern already used in auto_gptq.py:269 and auto_gptq.py:261 for the GPTQ/AWQ path.

Verification

  • Syntax validated by ruff check and ruff format --check
  • Logic matches the working GPTQ/AWQ path byte-for-byte
  • @kevinb361 independently confirmed the same fix enables W4A8 on 2x RTX 3090 with 1.36–1.61x TTFT speedup in his comment

Co-authored-by: noonghunna 10742901+noonghunna@users.noreply.github.com
Co-authored-by: kevinb361 91768207+kevinb361@users.noreply.github.com

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

PRs do not trigger a full CI run by default. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

Agent Guidelines

IMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban.

🚀

…ath (vllm-project#48904)

AutoRound (INC) checkpoints route through inc_wna16_linear.py and
inc_wna16_scheme.py, which construct Marlin linear/MoE methods but
never assign input_dtype.  The attribute defaults to None, so the
Marlin kernel never enters the int8-activation branch regardless of
the VLLM_MARLIN_INPUT_DTYPE env var.

Fix by setting method.input_dtype = get_marlin_input_dtype() after
construction, matching the pattern already used in auto_gptq.py:269
and auto_gptq.py:261 for the GPTQ/AWQ path.

Co-authored-by: noonghunna <10742901+noonghunna@users.noreply.github.com>
Co-authored-by: kevinb361 <91768207+kevinb361@users.noreply.github.com>
Signed-off-by: lazypool <lazypool@proton.me>
@lazypool
lazypool force-pushed the fix/inc-marlin-input-dtype branch from 67fb507 to 589f62c Compare July 18, 2026 14:34
@kevinb361

Copy link
Copy Markdown

I validated the exact #49039 commit on a real 2× RTX 3090 AutoRound deployment using vLLM 0.25.1, with the separate negative-scale workaround from #48905 applied.

Startup confirmed:

  • VLLM_MARLIN_INPUT_DTYPE=int8
  • MarlinLinearKernel selected on both TP workers
  • AutoRound negative group-scale folding engaged

A controlled 550,000-character prefill completed coherently:

  • TTFT: 47.566 s
  • wall time: 50.833 s
  • output: coherent one-sentence summary

This confirms the INC/AutoRound dtype propagation works in the real serving path. This run was not a matched W4A16 A/B, so I’m not treating it as a standalone speedup measurement. The negative-scale issue remains a separate prerequisite for this checkpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: VLLM_MARLIN_INPUT_DTYPE=int8 silently ignored for auto-round (INC) checkpoints

2 participants