[Rust Frontend] Fix macro-based content format detection#49042
Open
reidliu41 wants to merge 1 commit into
Open
[Rust Frontend] Fix macro-based content format detection#49042reidliu41 wants to merge 1 commit into
reidliu41 wants to merge 1 commit into
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Rust chat template detector only recognized loops directly over
message.content. It missed templates that pass the content into a macro anditerate with
{% for item in content %}.Qwen3.5 uses the macro form, causing
automode to incorrectly select thestring content format. Multimodal messages consequently lost the
<|vision_start|>and<|vision_end|>wrappers around<|image_pad|>, whichcould produce incorrect prompt tokens and multimodal positions.
Recognize loops over a
contentparameter while preserving the existingdirect
message.contentdetection. Add regression coverage using both aminimal macro template and the repository's Qwen3.5 template.
The corrected auto-detection matches the explicit OpenAI content format and
the corresponding Python detector behavior.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.