-
Notifications
You must be signed in to change notification settings - Fork 61
Fix/aboutbox #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/aboutbox #79
Conversation
contribution.md is still missing and should be created before this PR gets merged fixes #76 |
|
||
authorlabel.setText("Author: xavier cherif"); | ||
url ="https://github.com/vlsi/ksar/CONTRIBUTION.md"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaik, it should be CONTRIBUTING.md
for proper GitHub integration: https://github.com/blog/1184-contributing-guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is about "How to contribute " .. that's also missing.
For the moment I was more thinking on a list of contributors... e.g. antlr4 contributors. The current aboutbox just lists Xavier here as author..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I get the idea.
CONTRIBUTORS.md
might be better filename then.
@vlsi hmmm .. seems i somehow screwed the commits within the PR ... don't know if i can revert? anyhow ... i changed the URL to CONTRIBUTORS.md and provide also the file. |
The idea is to push the proper changes to your
Does that make sense? |
Note: ensure you have "contributors.md, etc changes" somewhere else before doing
|
0bece40
to
287a232
Compare
tried to rebase .. but it seems it is not a good idea during a PR. Did the reset and pushed the changes again. Please check the CONTRIBUTION.md file --> ok for you? |
I messed this up. Merging errors .. at least for me unresolvable .. will create a new PR |
update - url, author, license and tips label; make url clickable