Correctly apply nearby aggro on start opening "Treasure" gameobjects with the correct lockId

[FlagFlayer]

🍰 Pullrequest

Correctly applies aggro effect on opening spell start and only on gameobjects it's supposed to according to testing.

Corrects usage of factions 94, 101, 102, 114, and 1375 per sniffs.

Constructor overloading AnyUnfriendlyUnitInObjectRangeCheck so that it can take a WorldObject as a faction input.

Proof

From testing:

• Opening an object will only cause the aggro effect if it uses lockId 57 (for open objects) or a lockId that requires lockpicking to open.

• Further, the object must use a faction template that uses faction 77 ("Treasure"). Otherwise the aggro effect does not trigger. (These faction template IDs are 94, 100 (unused), 101, 102, 114, and 1375)

Results from testing on Classic 1.15 (can supply videos on request, forgot to film the objects that didn't cause aggro):

• Opening an object with correct lockId but without a "Treasure" faction, e.g. Cat Figurine (Faction 0, lockId 57) or Venture Co. Engineering Plans (Faction 84 - Alliance Generic, lockId 57) does not aggro nearby mobs.

• Opening an object with correct faction but incorrect lockId, e.g. Food Crate (Faction 94, lockId 43) does not aggro nearby mobs.

• Opening any object with faction 94 and lockId 57 results in aggro:

https://i.imgur.com/wDSV9do.mp4

• Opening an object with a lockpicking requirement (through any method) that has a "Treasure" faction results in aggro:

https://i.imgur.com/eLaEJCB.mp4

Issues

• 🐛 [Bug]Opening chests should aggro all nearby enemies while channeling the "open chest" spell #2363

How2Test

• Open a chest -> Aggros nearby mobs
• Open an object that has a different lockId and/or faction -> Does not aggro nearby mobs

Todo / Checklist

• None

[ratkosrb]

The indentation looks totally whack.

[FlagFlayer]

Looked fine on the file itself. I'll try and adjust it

[FlagFlayer]

Currently has an issue with handling factions 101 and 102 since the objects are openable by the object faction's friendly mask and should aggro based on the faction's hostile mask.

[FlagFlayer]

Currently has an issue with handling factions 101 and 102 since the objects are openable by the object faction's friendly mask and should aggro based on the faction's hostile mask.

Fixed now. Should be good to go.

[ShiyoKozuki]

I've been waiting for this for like 2 years!
Any chance you can merge in the current core to this? It has tons of merge conflicts if I try to take it as a PR.

[FlagFlayer]

I've been waiting for this for like 2 years! Any chance you can merge in the current core to this? It has tons of merge conflicts if I try to take it as a PR.

Done

[ShiyoKozuki]

Thank you! Works wonderfully.
However, this still has the bug where opening rogue lockers that require lock picking skill aggro everything. (i.e. lockers in wetlands, NOT locked TREASURE chests)

[FlagFlayer]

However, this still has the bug where opening rogue lockers that require lock picking skill aggro everything.

Yes. That is intended and correct behaviour. See this video from Classic.