Skip to content

Add .cve-fix/examples.md for CVE fixer workflow guidance (demo-with-cves) - #17

Closed
angaduom wants to merge 1 commit into
vmrh21:mainfrom
angaduom:demo-with-cves
Closed

Add .cve-fix/examples.md for CVE fixer workflow guidance (demo-with-cves)#17
angaduom wants to merge 1 commit into
vmrh21:mainfrom
angaduom:demo-with-cves

Conversation

@angaduom

Copy link
Copy Markdown

Summary

This PR adds .cve-fix/examples.md to provide repository-specific guidance for the CVE fixer workflow.

What's Included

  • 5 real CVE fix examples from repository history with commit references
  • Good Fix ✅ and Bad Fix ❌ patterns for each CVE
  • Monorepo lock file management guidelines (critical for ODH Dashboard)
  • npm overrides strategy for transitive dependencies
  • Testing checklist and commit message templates
  • Repository-specific rules for consistent CVE fixes

CVE Examples Documented

  1. CVE-2024-52798 - path-to-regexp ReDoS (Express upgrade)
  2. CVE-2025-7783 - form-data unsafe random (npm overrides)
  3. CVE-2024-21538 - cross-spawn ReDoS (npm overrides)
  4. CVE-2023-26115 - word-wrap ReDoS (npm overrides)
  5. CVE-2024-55565 - nanoid non-integer handling (lock file update)

Purpose

The CVE fixer workflow will:

  • Check for this file after cloning the repository
  • Load proven fix patterns from real historical commits
  • Apply the same successful strategies for new CVE fixes
  • Avoid common mistakes documented in "Bad Fix" sections

Key Patterns

Monorepo Lock File Management

# ALWAYS update ALL workspace lock files
npm install                      # Root
cd backend && npm install        # Backend
cd ../frontend && npm install    # Frontend

npm Overrides Strategy

{
  "overrides": {
    "vulnerable-package": "^fixed.version.0"
  }
}

Testing

  • ✅ File created with 361 lines of documentation
  • ✅ Based on actual commits from repository history
  • ✅ Includes real commit hashes for reference
  • ✅ Commit: 8410286

🤖 Generated by CVE Fixer Workflow

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

- Document 5 real CVE fixes from repository history
- Include good fix and bad fix examples for each CVE
- Add common patterns, testing checklist, and repository-specific rules
- Based on actual commits: path-to-regexp, form-data, cross-spawn, word-wrap, nanoid

This file provides guidance for the CVE fixer workflow to ensure
consistent, successful fixes following proven patterns.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@vmrh21

vmrh21 commented Feb 18, 2026

Copy link
Copy Markdown
Owner

lgtm

@angaduom angaduom closed this Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants