Skip to content
This repository was archived by the owner on Aug 21, 2020. It is now read-only.

created defined type to manage individual esxi syslog loggers#174

Open
tuxfight3r wants to merge 2 commits intovmware-archive:masterfrom
tuxfight3r:esx_syslog_loggers
Open

created defined type to manage individual esxi syslog loggers#174
tuxfight3r wants to merge 2 commits intovmware-archive:masterfrom
tuxfight3r:esx_syslog_loggers

Conversation

@tuxfight3r
Copy link

Defined type wrapper around esx_advanced_options to manage individual esxi syslog loggers
The wrapper is written in puppet 4 syntax, if needed hash merges with '+' can be changed to use merge function.

) {
#Common loggers available in a ESXi machine
#Options are mentioned here for reference only
#please uncomment the ones you are interested in
Copy link
Contributor

@crayfishx crayfishx Jun 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuxfight3r We should not be encouraging users to make modifications to module code. May I suggest that you change this to something like ....

$common = $::vcenter::logger_defaults

An init.pp base class (which currently doesn't exist) as:

class vcenter (
  Hash  $logger_defaults = {}
) {
}

These options should definately be documented, but not in a way that encourages (and indeed tells) the user to edit the module to enable them - they should be configured in Hiera, eg:

---
vcenter::logger_defaults:
  Syslog.loggers.dhclient.rotate: 8
  ....etc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants