This repository was archived by the owner on Aug 21, 2020. It is now read-only.
created defined type to manage individual esxi syslog loggers#174
Open
tuxfight3r wants to merge 2 commits intovmware-archive:masterfrom
Open
created defined type to manage individual esxi syslog loggers#174tuxfight3r wants to merge 2 commits intovmware-archive:masterfrom
tuxfight3r wants to merge 2 commits intovmware-archive:masterfrom
Conversation
| ) { | ||
| #Common loggers available in a ESXi machine | ||
| #Options are mentioned here for reference only | ||
| #please uncomment the ones you are interested in |
Contributor
There was a problem hiding this comment.
@tuxfight3r We should not be encouraging users to make modifications to module code. May I suggest that you change this to something like ....
$common = $::vcenter::logger_defaultsAn init.pp base class (which currently doesn't exist) as:
class vcenter (
Hash $logger_defaults = {}
) {
}These options should definately be documented, but not in a way that encourages (and indeed tells) the user to edit the module to enable them - they should be configured in Hiera, eg:
---
vcenter::logger_defaults:
Syslog.loggers.dhclient.rotate: 8
....etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined type wrapper around esx_advanced_options to manage individual esxi syslog loggers
The wrapper is written in puppet 4 syntax, if needed hash merges with '+' can be changed to use merge function.