This repository was archived by the owner on Aug 21, 2020. It is now read-only.
Proposed port of dell-asm#77 - Allow VDS to be created according to host versions#196
Open
crayfishx wants to merge 1 commit intovmware-archive:masterfrom
Open
Proposed port of dell-asm#77 - Allow VDS to be created according to host versions#196crayfishx wants to merge 1 commit intovmware-archive:masterfrom
crayfishx wants to merge 1 commit intovmware-archive:masterfrom
Conversation
- Allow creating VDS with specific version - Enabled search of host based on the VDS version
| create_spec = RbVmomi::VIM::DVSCreateSpec.new | ||
| create_spec.configSpec = RbVmomi::VIM::DVSConfigSpec.new | ||
| create_spec.configSpec.name = basename | ||
| if @dvswitch.nil? && resource[:vds_version] |
Contributor
There was a problem hiding this comment.
@dvswitch.nil? seems unnecessarily redundant since this is the create method and @DVSwitch is set by the method triggered by the exists? method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised in #188
Original PR https://github.com/dell-asm/vmware-vcenter/pull/77
Original commit message