This repository was archived by the owner on Aug 21, 2020. It is now read-only.
esx_advanced_options: convert integers to strings#202
Open
crayfishx wants to merge 1 commit intovmware-archive:masterfrom
Open
esx_advanced_options: convert integers to strings#202crayfishx wants to merge 1 commit intovmware-archive:masterfrom
crayfishx wants to merge 1 commit intovmware-archive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #175 (and also raised in #172) if integers are supplied from the
esx_advanced_optionsresource type there is some hard to identify behaviour. Since the solution is to always provide numbers as strings, this PR munges the given hash in the resource type so integers are converted into strings.Note, I assume that booleans and possibly other types are valid, therefore we only convert integers to strings.
Tests added to assert the above.