Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Update subpath from DeepCopy instead of pointer" #598

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

warango4
Copy link
Contributor

This reverts commit 3cedc29.

Pull request

What this PR does / why we need it

Revert unexpected breaking change introduced in #580

Which issue(s) this PR fixes

N/A

Describe testing done for PR

Additional information or special notes for your reviewer

@warango4
Copy link
Contributor Author

When changing from Git source to LSP

image

@warango4
Copy link
Contributor Author

When changing from LSP to source image, subpath stays

image

@warango4 warango4 merged commit 906f7b2 into vmware-tanzu:main Jun 13, 2023
@warango4 warango4 deleted the subpath-rollback branch June 13, 2023 18:02
warango4 added a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants