Skip to content

Conversation

Duncaen
Copy link
Member

@Duncaen Duncaen commented Jan 10, 2024

Updated version of #359, same results slightly different with less changes and ready to merge.

xbps_file_hash_check_dictionary was called for every file that is
getting unpacked, because the files list is an array it iterated over
the whole files array to find the matching file.
With a lot of files this is really slow and a lot of time was spend
in locking the proplib array and iterating over it.

Time from my Ryzen 3700X system with nvme disk updating
texlive-fontsextra with files 86375:

time xbps-install -y texlive-fontsextra
    6m34.61s real     6m27.71s user     0m03.95s system

And with this patch:

time xbps-install -y texlive-fontsextra
    0m08.40s real     0m07.34s user     0m00.98s system

@Duncaen Duncaen force-pushed the replace-xbps_hash_file_check_dictionary branch from 89889d5 to b1831a6 Compare January 11, 2024 14:38
@Duncaen Duncaen force-pushed the replace-xbps_hash_file_check_dictionary branch from 8168470 to 06981f1 Compare January 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant