Skip to content

test(snapshots): stabilize external tool output #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Aug 29, 2026
Merged

test(snapshots): stabilize external tool output #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23bcbc9
test(snapshots): pin external tool versions
fengmk2 Aug 29, 2026
37c50a9
test(snapshots): use pnpm 11 fixture
fengmk2 Aug 29, 2026
fc88631
test(snapshots): hide unordered build output
fengmk2 Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...i_snapshots/tests/cli_snapshots/fixtures/command_pack_picomatch_hoist_false/.node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
24.19.0
4 changes: 2 additions & 2 deletions ...vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_from_tsup_monorepo/snapshots.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ steps = [
{ argv = ["vpt", "stat-file", "packages/b/tsup.config.ts", "--assert-not", "file"], comment = "package b original config is removed" },
{ argv = ["vpt", "print-file", "packages/b/tsdown.config.ts"], comment = "package b gets a converted config" },
{ argv = ["vpt", "print-file", "packages/b/package.json"], comment = "package b uses vp pack" },
{ argv = ["vp", "run", "build"], cwd = "packages/a", comment = "package a migrated vp pack script builds successfully" },
{ argv = ["vp", "run", "build"], cwd = "packages/a", comment = "package a migrated vp pack script builds successfully", snapshot = false },
{ argv = ["vpt", "list-dir", "packages/a/dist"], comment = "package a build artifacts are created" },
{ argv = ["vp", "run", "build"], cwd = "packages/b", comment = "package b migrated vp pack script builds successfully" },
{ argv = ["vp", "run", "build"], cwd = "packages/b", comment = "package b migrated vp pack script builds successfully", snapshot = false },
{ argv = ["vpt", "list-dir", "packages/b/dist"], comment = "package b build artifacts are created" },
]

Expand Down
20 changes: 0 additions & 20 deletions .../migration_from_tsup_monorepo/snapshots/migration_from_tsup_monorepo_success.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,6 @@ package b uses vp pack

package a migrated vp pack script builds successfully

```
~/packages/a$ vp pack ⊘ cache disabled
ℹ entry: src/index.ts
ℹ Build start
ℹ dist/index.cjs <size> kB │ gzip: <size> kB
ℹ 1 files, total: <size> kB
ℹ dist/index.d.cts <size> kB │ gzip: <size> kB
ℹ 1 files, total: <size> kB
✔ Build complete in <duration>
```

## `vpt list-dir packages/a/dist`

Expand All @@ -129,16 +119,6 @@ index.d.cts

package b migrated vp pack script builds successfully

```
~/packages/b$ vp pack ⊘ cache disabled
ℹ entry: src/index.ts
ℹ Build start
ℹ dist/index.cjs <size> kB │ gzip: <size> kB
ℹ 1 files, total: <size> kB
ℹ dist/index.d.cts <size> kB │ gzip: <size> kB
ℹ 1 files, total: <size> kB
✔ Build complete in <duration>
```

## `vpt list-dir packages/b/dist`

Expand Down
2 changes: 1 addition & 1 deletion ..._snapshots/tests/cli_snapshots/fixtures/shim_pnpm_uses_project_node_version/.node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.12.0
22.18.0
4 changes: 2 additions & 2 deletions ...snapshots/tests/cli_snapshots/fixtures/shim_pnpm_uses_project_node_version/snapshots.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "shim_pnpm_uses_project_node_version"
vp = "global"
skip-platforms = ["windows"]
steps = [
{ argv = ["vp", "install", "-g", "pnpm"], comment = "Ensure pnpm is globally installed", snapshot = false, continue-on-failure = true },
{ argv = ["vp", "install", "-g", "pnpm@11.20.0"], comment = "Install a fixed JS-based pnpm version", snapshot = false, continue-on-failure = true },
{ argv = ["vp", "env", "exec", "node", "-v"], comment = "Node version resolved from .node-version", continue-on-failure = true },
{ argv = ["vp", "env", "exec", "pnpm", "exec", "node", "-v"], comment = "pnpm should use same project Node version", continue-on-failure = true },
{ argv = ["vp", "env", "exec", "pnpm", "--silent", "exec", "node", "-v"], comment = "pnpm should use same project Node version", continue-on-failure = true },
]
6 changes: 3 additions & 3 deletions ...pnpm_uses_project_node_version/snapshots/shim_pnpm_uses_project_node_version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# shim_pnpm_uses_project_node_version

## `vp install -g pnpm`
## `vp install -g pnpm@11.20.0`

Ensure pnpm is globally installed
Install a fixed JS-based pnpm version


## `vp env exec node -v`
Expand All @@ -13,7 +13,7 @@ Node version resolved from .node-version
<version>
```

## `vp env exec pnpm exec node -v`
## `vp env exec pnpm --silent exec node -v`

pnpm should use same project Node version

Expand Down
Loading