Add tracks support#10
Conversation
Add support for getting tracks from the SK server that the app was loaded from.
Instead of a custom JSON we can use vanilla GeoJSON FeatureCollection and use GeoJSON properties for storing metadata for each track === Feature.
If the response contains extra data in addition to the track positions in the individual coordinates arrays and they are enumerated in the top FeatureCollection property dataPaths render them as colored points and rings. Supports 2 distinct series. Includes hover popups to display the value with timestamp.
|
|
Start making the data to fetch configurable and fetch units from the server, caching them locally to skip a few http requests.
|
Hi, Could you PR on my fork on a seperate branch. |
|
@FredericGuilbault I don’t understand what you are after. Please read up on Github https://guides.github.com/activities/forking/ https://guides.github.com/introduction/flow/ |
|
I taught I would loose the info about commiters if I was the one adding your upstream and push. but it's ok. FTR that's what I did : Now I will good :D |
| import _ from 'lodash' | ||
| import {COG, HDG, MAX_ZOOM, MIN_ZOOM, EXTENSION_LINE_OFF, EXTENSION_LINE_2_MIN, EXTENSION_LINE_5_MIN, EXTENSION_LINE_10_MIN} from './enums' | ||
| import Map from './map' | ||
| import Connection from './data-connection' |
There was a problem hiding this comment.
Refactoring code from of the master branch inside a feature branch should be avoided. It's a PITA when it come to merge multiple branches. Refactoring process are bumpy enough to worth it's own branch :D.
3 participants
This PR supercedes #2 so that it includes everything that PR has and additionally
starttimeandnameproperties