add minAvailable anno key #154
Conversation
|
Welcome @sceneryback! |
|
/assign @hzxuzhonghu |
| @@ -35,6 +35,10 @@ const KubeGroupNameAnnotationKey = "scheduling.k8s.io/group-name" | |||
| // which PodGroup it belongs to. | |||
| const VolcanoGroupNameAnnotationKey = GroupName + "/group-name" | |||
|
|
|||
| // VolcanoGroupMinAvailableAnnotationKey is the annotation key of Pod controllers (e.g. Deployment) to identify | |||
| // the minimum available member of PodGroup. | |||
| const VolcanoGroupMinAvailableAnnotationKey = GroupName + "/minAvailable" | |||
There was a problem hiding this comment.
I prefer minMember here.
We had some discussion in
volcano-sh/volcano#3970 (comment)
volcano-sh/volcano#3970 (comment)
@Monokaix @JesseStutler @lowang-bh
What do you think?
There was a problem hiding this comment.
Yes, I think minMember is easily associated with podgroup's minMember for user.
There was a problem hiding this comment.
hi @hwdef @lowang-bh what about 'scheduling.volcano.sh/group-min-member'? So users would easily know it's designed for PodGroup, just as the existing one 'scheduling.volcano.sh/group-min-resources'
There was a problem hiding this comment.
Yes, it's OK.
Updated
Signed-off-by: sceneryback <[email protected]>
sceneryback
force-pushed
the
labels_add_minAvailable
branch
from
72a5ae5 to
97e5eec
Compare
|
PTAL @JesseStutler @Monokaix |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part changes of volcano-sh/volcano#4000