Skip to content

fix(openclaw-plugin): sanitize memory_store input to prevent context pollution #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mobilebarn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(openclaw-plugin): sanitize memory_store input to prevent context pollution #1031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions examples/openclaw-plugin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type { FindResultItem, PendingClientEntry } from "./client.js";
import {
isTranscriptLikeIngest,
extractLatestUserText,
sanitizeUserTextForCapture,
} from "./text-utils.js";
import {
clampScore,
Expand Down Expand Up @@ -243,6 +244,13 @@ const contextEnginePlugin = {
}),
async execute(_toolCallId: string, params: Record<string, unknown>) {
const { text } = params as { text: string };
const sanitizedText = sanitizeUserTextForCapture(text);
if (!sanitizedText) {
return {
content: [{ type: "text", text: "Nothing to store after sanitizing input (metadata-only content was stripped)." }],
details: { action: "rejected", reason: "empty_after_sanitize" },
};
}
const role =
typeof (params as { role?: string }).role === "string"
? (params as { role: string }).role
Expand All @@ -251,7 +259,7 @@ const contextEnginePlugin = {
const sessionKeyIn = (params as { sessionKey?: string }).sessionKey;

api.logger.info?.(
`openviking: memory_store invoked (textLength=${text?.length ?? 0}, sessionId=${sessionIdIn ?? "auto"}, sessionKey=${sessionKeyIn ?? "none"})`,
`openviking: memory_store invoked (textLength=${sanitizedText.length}, sessionId=${sessionIdIn ?? "auto"}, sessionKey=${sessionKeyIn ?? "none"})`,
);

let sessionId = sessionIdIn;
Expand All @@ -269,7 +277,7 @@ const contextEnginePlugin = {
details: { action: "rejected", reason: "missing_session_identifier" },
};
}
await c.addSessionMessage(sessionId, role, text, storeAgentId);
await c.addSessionMessage(sessionId, role, sanitizedText, storeAgentId);
const commitResult = await c.commitSession(sessionId, { wait: true, agentId: storeAgentId });
const memoriesCount = commitResult.memories_extracted ?? 0;
if (memoriesCount === 0) {
Expand Down