Skip to content

fix(bot): polish interactive card per review feedback#1046

Open
r266-tech wants to merge 1 commit intovolcengine:mainfrom
r266-tech:fix/feishu-card-polish
Open

fix(bot): polish interactive card per review feedback#1046
r266-tech wants to merge 1 commit intovolcengine:mainfrom
r266-tech:fix/feishu-card-polish

Conversation

@r266-tech
Copy link
Copy Markdown
Contributor

Follow-up to #1015. Addresses review feedback from @yeshion23333.

Changes

  1. [P1] Add config.wide_screen_mode to card payload — Without wide_screen_mode, long text and tables may be truncated. Also aligns the card JSON with official Feishu card schema, reducing the chance of strict validation failures.

  2. [P1] Add alt field to img elements — Card images now include {"tag": "plain_text", "content": ""} for schema completeness, matching official card examples.

  3. [P2] Quote id in @mention tag — Changed <at id=xxx> to <at id="xxx"> to reduce parsing ambiguity in stricter rendering paths.

Follow-up to volcengine#1015. Addresses review comments from yeshion23333:

1. Add config.wide_screen_mode to card payload to prevent text/table
   truncation and align with official card schema
2. Add alt field to img elements for card schema completeness
3. Quote id attribute in @mention tag for parser compatibility
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants