Skip to content

fix: correct context_type classification for memories during reindex #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muxiaomu001 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix: correct context_type classification for memories during reindex #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openviking/storage/queuefs/semantic_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from dataclasses import dataclass, field
from typing import Awaitable, Callable, Dict, List, Optional

from openviking.core.directories import get_context_type_for_uri
from openviking.server.identity import RequestContext
from openviking.storage.viking_fs import get_viking_fs
from openviking_cli.utils import VikingURI
Expand Down Expand Up @@ -440,7 +441,7 @@ async def _file_summary_task(self, parent_uri: str, file_path: str) -> None:
task = VectorizeTask(
task_type="file",
uri=file_path,
context_type=self._context_type,
context_type=get_context_type_for_uri(file_path),
ctx=self._ctx,
semantic_msg_id=self._semantic_msg_id,
file_path=file_path,
Expand Down Expand Up @@ -560,7 +561,7 @@ async def _overview_task(self, dir_uri: str) -> None:
task = VectorizeTask(
task_type="directory",
uri=dir_uri,
context_type=self._context_type,
context_type=get_context_type_for_uri(dir_uri),
ctx=self._ctx,
semantic_msg_id=self._semantic_msg_id,
abstract=abstract,
Expand Down
5 changes: 3 additions & 2 deletions openviking/utils/summarizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,11 @@ async def summarize(
telemetry = get_current_telemetry()
for uri, temp_uri in zip(resource_uris, temp_uris):
# Determine context_type based on URI
# Use the same logic as core/directories.get_context_type_for_uri()
context_type = "resource"
if uri.startswith("viking://memory/"):
if "/memories" in uri:
context_type = "memory"
elif uri.startswith("viking://agent/skills/"):
elif "/skills" in uri:
context_type = "skill"

msg = SemanticMsg(
Expand Down