Skip to content

[RFC]feat: Implement google play music - #315

Open
vkbinfo wants to merge 6 commits into
volumio:masterfrom
vkbinfo:feature/google_play_music
Open

[RFC]feat: Implement google play music#315
vkbinfo wants to merge 6 commits into
volumio:masterfrom
vkbinfo:feature/google_play_music

Conversation

@vkbinfo

@vkbinfo vkbinfo commented Mar 15, 2019

Copy link
Copy Markdown

This Implementation implements the following features of Google Play Music:

  • User playlist
  • Station feature of Google Play Music
  • Search Functionality on a given string

@vkbinfo
vkbinfo force-pushed the feature/google_play_music branch 2 times, most recently from 6e39563 to 3763d40 Compare March 28, 2019 21:58
@vkbinfo

vkbinfo commented Apr 2, 2019

Copy link
Copy Markdown
Author

play_playlist
Preview Playlist Play

@vkbinfo vkbinfo changed the title [WIP]feat: Implement google play music [RFC]feat: Implement google play music Apr 7, 2019
@vkbinfo

vkbinfo commented Apr 7, 2019

Copy link
Copy Markdown
Author

Search
play_search

@vkbinfo

vkbinfo commented Apr 7, 2019

Copy link
Copy Markdown
Author

Station
play_station

@vkbinfo
vkbinfo marked this pull request as ready for review April 7, 2019 02:08
@vkbinfo

vkbinfo commented Apr 10, 2019

Copy link
Copy Markdown
Author

Login window for Google Play Music Login:-
Screenshot 2019-04-11 at 5 02 15 AM

@volumio

volumio commented Apr 10, 2019

Copy link
Copy Markdown
Owner

Very good. Few suggestions:
-Remove the high bitrate option if not used

@vkbinfo
vkbinfo force-pushed the feature/google_play_music branch from 95ff9be to 7fde44e Compare April 11, 2019 01:02
@volumio

volumio commented Apr 15, 2019

Copy link
Copy Markdown
Owner

Not good for merging, it fails to start.
How to replicate:

  • Install the plugin (on a new system)
  • Go to plugin settings an enable it
  • It will fail the start and crash the system

This is the trace:
nnect2","name":"volspotconnect2","category":"music_service","version":"0.9.1","icon":"fa-spotify","enabled":true,"active":true}]
Apr 15 20:13:59 primo volumio[6772]: info: Enabling plugin googleplaymusic
Apr 15 20:13:59 primo volumio[6772]: info: Loading plugin "googleplaymusic"...
Apr 15 20:13:59 primo volumio[6772]: info: Applying required configuration parameters for plugin googleplaymusic
Apr 15 20:13:59 primo volumio[6772]: info: PLUGIN START: googleplaymusic
Apr 15 20:13:59 primo volumio[6772]: info: CoreCommandRouter::volumioAddToBrowseSources[object Object]
Apr 15 20:13:59 primo volumio[6772]: info: [1555359239503] CoreMusicLibrary::Adding element Google Play Music
Apr 15 20:13:59 primo volumio[6772]: info: CoreCommandRouter::executeOnPlugin: my_music , getDisabledSources
Apr 15 20:13:59 primo volumio[6772]: I am getting token for access
Apr 15 20:13:59 primo volumio[6772]: Failed To get access Token Google Play mUsic Error: Unable to create oauth tokenError: You must provide either an email address and password, or a token
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:121:33
Apr 15 20:13:59 primo volumio[6772]: at PlayMusic._oauth (/data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:169:9)
Apr 15 20:13:59 primo volumio[6772]: at PlayMusic.init (/data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:120:10)
Apr 15 20:13:59 primo volumio[6772]: at getTokenFromPlayMusic (/data/plugins/music_service/googleplaymusic/index.js:122:21)
Apr 15 20:13:59 primo volumio[6772]: at playMusicController.onStart (/data/plugins/music_service/googleplaymusic/index.js:109:17)
Apr 15 20:13:59 primo volumio[6772]: at PluginManager.startPlugin (/volumio/app/pluginmanager.js:335:36)
Apr 15 20:13:59 primo volumio[6772]: at nextTickCallback (/volumio/node_modules/kew/kew.js:47:28)
Apr 15 20:13:59 primo volumio[6772]: at _combinedTickCallback (internal/process/next_tick.js:131:7)
Apr 15 20:13:59 primo volumio[6772]: at process._tickCallback (internal/process/next_tick.js:180:9)
Apr 15 20:13:59 primo volumio[6772]: info: Error: Error
Apr 15 20:13:59 primo volumio[6772]: Failed To get access Token Google Play mUsic Error: Unable to create oauth tokenError: 403 error from server
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:121:33
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:181:9
Apr 15 20:13:59 primo volumio[6772]: at IncomingMessage. (/data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:86:48)
Apr 15 20:13:59 primo volumio[6772]: at emitNone (events.js:111:20)
Apr 15 20:13:59 primo volumio[6772]: at IncomingMessage.emit (events.js:208:7)
Apr 15 20:13:59 primo volumio[6772]: at endReadableNT (_stream_readable.js:1064:12)
Apr 15 20:13:59 primo volumio[6772]: at _combinedTickCallback (internal/process/next_tick.js:138:11)
Apr 15 20:13:59 primo volumio[6772]: at process._tickCallback (internal/process/next_tick.js:180:9)
Apr 15 20:13:59 primo volumio[6772]: |||||||||||||||||||||||| WARNING: FATAL ERROR |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Apr 15 20:13:59 primo volumio[6772]: Error: Unable to resolve or reject the same promise twice
Apr 15 20:13:59 primo volumio[6772]: at Promise.reject (/data/plugins/music_service/googleplaymusic/node_modules/kew/kew.js:189:43)
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/index.js:130:20
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:121:24
Apr 15 20:13:59 primo volumio[6772]: at /data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:181:9
Apr 15 20:13:59 primo volumio[6772]: at IncomingMessage. (/data/plugins/music_service/googleplaymusic/node_modules/playmusic/play.js:86:48)
Apr 15 20:13:59 primo volumio[6772]: at emitNone (events.js:111:20)
Apr 15 20:13:59 primo volumio[6772]: at IncomingMessage.emit (events.js:208:7)
Apr 15 20:13:59 primo volumio[6772]: at endReadableNT (_stream_readable.js:1064:12)
Apr 15 20:13:59 primo volumio[6772]: at _combinedTickCallback (internal/process/next_tick.js:138:11)
Apr 15 20:13:59 primo volumio[6772]: at process._tickCallback (internal/process/next_tick.js:180:9)
Apr 15 20:13:59 primo volumio[6772]: |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||

@vkbinfo

vkbinfo commented Apr 15, 2019

Copy link
Copy Markdown
Author

I will fix it, I did not handle this edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants