PBX-29: Migrate Kazoo to OTP 25 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cking-vonix
reviewed
Apr 1, 2024
| @@ -810,7 +810,8 @@ handle_cast('logout_agent', #state{acct_id=AcctId | |||
| lager:debug("published agent logout message"), | |||
| {'noreply', State}; | |||
|
|
|||
| handle_cast({'presence_id', _Id}, #state{agent_presence_id=_Id}=State) -> | |||
|
|
|||
There was a problem hiding this comment.
Minor lint issue: clean up this extra whitespace
cking-vonix
reviewed
Apr 1, 2024
rel/relx.config
Outdated
| {overlay, [{copy, "../core/sup/priv/sup", "{{output_dir}}/bin/"} | ||
| ,{copy, "nodetool", "{{output_dir}}/bin/"} | ||
| ,{template, "kazoo", "{{output_dir}}/bin/kazoo"} | ||
| {overlay, [{copy, "/core/sup/priv/sup", "{{output_dir}}/bin/"} |
There was a problem hiding this comment.
this should not have a leading / on it (should be "core/sup/priv/sup")
cking-vonix
reviewed
Apr 1, 2024
relx.config
Outdated
There was a problem hiding this comment.
This entire file is not needed, the relx.config files are in the rel/ directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBX-29: Migrate Kazoo to OTP 25