bititer

robert3005 · robert3005 · commit 24c4b979661a · 2025-05-19T20:03:28.000+01:00
diff --git a/vortex-buffer/src/bit/bit_iter.rs b/vortex-buffer/src/bit/bit_iter.rs
@@ -173,7 +173,10 @@ impl Iterator for BitIterator {
         if self.current_offset == self.end_offset {
             return None;
         }
-        self.end_offset -= 1;
+        // SAFETY: Offset is in bounds
+        let v = self.buffer[self.current_offset / 8] & (1 << (self.current_offset % 8)) != 0;
+        self.current_offset += 1;
+        Some(v)
     }
 
     fn size_hint(&self) -> (usize, Option<usize>) {

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,10 @@ impl Iterator for BitIterator {`
`173`	`173`	`if self.current_offset == self.end_offset {`
`174`	`174`	`return None;`
`175`	`175`	`}`
`176`		`- self.end_offset -= 1;`
	`176`	`+ // SAFETY: Offset is in bounds`
	`177`	`+ let v = self.buffer[self.current_offset / 8] & (1 << (self.current_offset % 8)) != 0;`
	`178`	`+ self.current_offset += 1;`
	`179`	`+ Some(v)`
`177`	`180`	`}`
`178`	`181`
`179`	`182`	`fn size_hint(&self) -> (usize, Option<usize>) {`