Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disclose publisher option #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disclose publisher option #73

wants to merge 2 commits into from

Conversation

al7373
Copy link

@al7373 al7373 commented Jan 14, 2018 •
edited
Loading

@davidwdan
Here is a proposed fix for Issue #25.

Please let me know if you have any recommended changes.

Thanks,
Alain

@ThePixelDeveloper
Copy link
Contributor

This goes well with #79. Hope to see this included as well. 👍

@ThePixelDeveloper
Copy link
Contributor

@al7373 Mind resolving the conflicts?
@davidwdan If the conflicts are resolved would this be good to merge?

mbonneau
mbonneau requested changes May 2, 2018
View reviewed changes
Copy link
Member

@mbonneau mbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except that it should only set the option if set in the annotation. This also needs to be reworked into the current master branch.

src/Voryx/ThruwayBundle/WampKernel.php

//Subscribe Options
$subscribeOptions = [
'disclose_publisher' => $disclosePublisher
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see disclose_publisher only set if there is an option set, not for every subscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbonneau mbonneau mbonneau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al7373 @ThePixelDeveloper @mbonneau