Skip to content

Conversation

fzoske
Copy link

@fzoske fzoske commented Dec 9, 2019

Pull Request (PR) description

This change enforce the usage of the managed repository to work around the AppStream of CentOS and RedHat, which will take precedence over none module based repositories.

This Pull Request (PR) fixes the following issues


$_package_install_options ? {
$manage_repo => '--repo=nginx-release',
default => '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be undef

default => 'rhel'
}

$_package_install_options ? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something missing here.

@bastelfreak bastelfreak added the enhancement New feature or request label Dec 31, 2019
@bastelfreak
Copy link
Member

This basically adds RedHat 8 support, right? If so, can you please add CentOS 8 / RedHat 8 to the metadata.json? This depends on voxpupuli/facterdb#137

@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Dec 31, 2019
@vox-pupuli-tasks
Copy link

Dear @fzoske, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-work not ready to merge just yet tests-fail

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants