Skip to content

Don't delete temporary file before using it #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't delete temporary file before using it #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/puppet/provider/openldap_global_conf/olc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,13 @@ def create
t << "add: olc#{resource[:name]}\n"
t << "olc#{resource[:name]}: #{resource[:value]}\n"
end
t.close
Puppet.debug(File.read(t.path))
begin
ldapmodify(t.path)
rescue Exception => e
raise Puppet::Error, "LDIF content:\n#{File.read t.path}\nError message: #{e.message}"
ensure
t.close
end
@property_hash[:ensure] = :present
end
Expand All @@ -99,12 +100,13 @@ def destroy
else
t << "delete: olc#{name}\n"
end
t.close
Puppet.debug(File.read(t.path))
begin
ldapmodify(t.path)
rescue Exception => e
raise Puppet::Error, "LDIF content:\n#{File.read t.path}\nError message: #{e.message}"
ensure
t.close
end
@property_hash.clear
end
Expand Down Expand Up @@ -139,12 +141,13 @@ def value=(value)
t << "replace: olc#{name}\n"
t << "olc#{name}: #{value}\n"
end
t.close
Puppet.debug(File.read(t.path))
begin
ldapmodify(t.path)
rescue Exception => e
raise Puppet::Error, "LDIF content:\n#{File.read t.path}\nError message: #{e.message}"
ensure
t.close
end
@property_hash[:value] = value
end
Expand Down