chore: finalize standards compliance - #27
Merged
Merged
Conversation
Change typescript from pinned "5.9.3" to "^5.9.3" to allow compatible patch/minor updates per standards compliance.
- Set up Vitest with React Testing Library and jsdom environment - Extract cn() utility (clsx + tailwind-merge) to src/lib/cn.ts - Extract navItems and siteMetadata constants to src/lib/constants.ts - Extract redirect config to src/lib/redirects.ts for testability - Add 31 unit tests across 4 test files: - cn.test.ts: class merging, tailwind conflict resolution - constants.test.ts: navigation items and metadata validation - redirects.test.ts: legacy URL mapping and redirect rules - sidebar.test.tsx: component rendering and active state - Update test scripts: "test" runs vitest, e2e moved to "test:e2e"
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"typescript": "5.9.3"to"^5.9.3"(caret range per standards)@testing-library/jest-dommatcherscn()utility into dedicatedsrc/lib/files for better testability and separation of concernscn()utility, navigation constants, redirect rules, and Sidebar component renderingnpm testnow runs Vitest unit tests; Playwright e2e tests moved tonpm run test:e2eStandards addressed
5.9.3instead of^5.9.3Test plan
npm test(vitest) — 31 tests passnpm run build— Next.js build succeedsnpm run lint— no warnings or errorsnpm run test:e2e— Playwright e2e tests (requires dev server)