Add dark/light theme variants to screenshot pipeline - #31
Merged
Conversation
Capture 4 screenshot combinations per page (dark desktop, dark mobile, light desktop, light mobile) instead of just 2 (desktop, mobile). - Add setTheme() helper in e2e/visual.ts to switch theme via localStorage and document class - Update screenshots.spec.ts to iterate over both themes for each page - Update PR comment page status table to show 4 columns for all variants https://claude.ai/code/session_01EFFjyzUiPaF1gBYnNVutHN
Remove old 2-variant baselines (desktop/mobile) and add new 4-variant baselines (dark-desktop, dark-mobile, light-desktop, light-mobile) for all 5 pages. https://claude.ai/code/session_01EFFjyzUiPaF1gBYnNVutHN
🔍 PR Validation ✅
📋 Checks
✅ Visual RegressionAll 30 screenshots match baselines — no visual changes detected. 📸 Page Status
🚀 Ready to merge! 🔗 Workflow run · ⬇️ Download all screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture 4 screenshot combinations per page (dark desktop, dark mobile,
light desktop, light mobile) instead of just 2 (desktop, mobile).
and document class